[Bug 168227] Review request: perl-HTTP-Server-Simple-Mason - HTTP::Server::Simple::Mason Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-HTTP-Server-Simple-Mason - HTTP::Server::Simple::Mason Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168227


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |jpo at di.uminho.pt
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpo at di.uminho.pt  2005-09-22 08:27 EST -------
NEEDSWORK

MD5SUMS:
2c0ea17e0911302bf8ae96c5dfe915c2  perl-HTTP-Server-Simple-Mason-0.09-1.src.rpm

89801442d5ed9b39a80605546461712e  HTTP-Server-Simple-Mason-0.09.tar.gz
a339dbaa5c200fa268bf250e8a9006e7  perl-HTTP-Server-Simple-Mason.spec

Good:
* Package name follows standard
* Tarball MD5 disget verified
* License verified
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions are correct
* Builds without problems in FC-4


NeedsWork:

* invalid Source0 URL

  it should be
  http://www.cpan.org/authors/id/J/JE/JESSE/...
  (s#CPAN/##)
  or·
  http://search.cpan.org/CPAN/authors/id/J/JE/JESSE/...
  (s/www/search/)

* missing requirement: perl(HTTP::Server::Simple::CGI)

  Mason.pm
  --------
  package HTTP::Server::Simple::Mason;
  use base qw/HTTP::Server::Simple::CGI/;
  ....

* directory ownership should start at

    %{perl_vendorlib}/HTTP/Server/Simple/

  as it requires HTTP::Server::Simple


Improvements:

* add the BR LWP::Simple to improve test coverage

* add the example in ex/


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.