[Bug 168624] Review Request: hspell: a Hebrew spell checker

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hspell: a Hebrew spell checker


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168624





------- Additional Comments From tcallawa at redhat.com  2005-09-25 17:18 EST -------
Review:

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

Nitpick:

You should probably include COPYING as a %doc for the main package as well, but
thats a minor issue, not a blocker.

APPROVED.

Go ahead and put in your paperwork for sponsorship, and I'll sponsor you. Good
work. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.