[Bug 165612] Review Request: gfontview
bugzilla at redhat.com
bugzilla at redhat.com
Mon Sep 26 07:49:27 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gfontview
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165612
gauret at free.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |gauret at free.fr
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From gauret at free.fr 2005-09-26 03:49 EST -------
Review:
* BuildRoot: should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Missing SMP flags ( make %{?_smp_mflags} )
* BuildRquires should be gtk+-devel, not gtk+. Please tests your package build
in mock to make sure no BR is missing.
* Please drop the Mandriva-specific header
* Don't set Vendor or Packager, they are set by the build system
* just use %configure instead of ./configure --prefix=
* replace /usr/share/ with %{_datadir}
* install with "make DESTDIR=$RPM_BUILD_ROOT install"
* %post is empty, you can remove it
* in the %files list, use %{_bindir} instead of %{prefix}/bin and %{_datadir}
instead of %{prefix}/share
* use the %{find_lang} macro to find the language files and tag them as such.
An example spec file for Fedora can be found in the fedora-rpmdevtools package
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list