[Bug 168608] Review Request: emelFM2

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 26 22:21:11 UTC 2005

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emelFM2


------- Additional Comments From wickerpms at arcor.de  2005-09-26 18:20 EST -------
(In reply to comment #1)
> - Both patches contain hardcoded paths (/usr/share in patch0 and /usr in
> patch1). It has to be %{_datadir} and %{_prefix} respectively. You could for
> example use %DATADIR% and %PREFIX% in your patches and do sed substitution in
> %prep to set the right path.
Thanks. Did that with prefix in Makefile.config.
Removed broken-icon path using only sed instead.

> - In the specfile, you defined the patches names with %{version} included. It is
> going to cause trouble on the next package update. You'd better replace it with
> 0.1.2.

> - In %install, you use %{prefix}. It should be %{_prefix} (with underscore)

> - The package sould own %{_libdir}/%{name} and %{_datadir}/pixmaps/%{name}

Updated SPEC:

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

More information about the fedora-extras-list mailing list