[Bug 165353] Review Request: A natural language translation library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: A natural language translation library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165353


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-09-06 20:08 EST -------
Review:

Good:

- rpmlint output: 
E: libtranslate outside-libdir-files /usr/share/libtranslate/services.dtd
Safe to ignore.
- meets naming guidelines
- license BSD ok, license text in %doc, matches source
- spec file in Am. English, legible
- source matches upstream
- compiles on devel (x86)
- no missing, unnecessary BR
- locales handled properly
- post/postun ldconfig ok
- not relocatable
- owns all directories that it creates
- no duplicate files in %files
- permissions on files ok
- clean ok
- macros consistent
- code, not content     
- no need for -docs
- nothing in %doc affects runtime     
- headers and .a in -devel
- pkgconfig file in -devel
- suffixed libs in main package
- devel requires base using n-v-r
- no la libtool archives
- no need for .desktop

Needsfix:
- Buildroot should be :
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Nitpick:
- You don't need to do this:

%dir %{_libdir}/libtranslate/
%dir %{_libdir}/libtranslate/modules/
%{_libdir}/libtranslate/modules/*.so

Instead, just do:

%{_libdir}/libtranslate/

That will give you directory ownership of %{_libdir}/libtranslate/, all the
directories beneath it, and all the files in it.

Please correct the Needsfix and the Nitpick items before committing, but this
package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.