[Bug 167511] Review Request: perl-Apache-Session
bugzilla at redhat.com
bugzilla at redhat.com
Wed Sep 7 23:35:20 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Apache-Session
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167511
tcallawa at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |tcallawa at redhat.com
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From tcallawa at redhat.com 2005-09-07 19:35 EST -------
You beat me to this one by four days. ;)
Review:
Good:
- rpmlint checks return nothing
- meets naming, packaging guidelines
- spec in am. english, legible
- source matches upstream
- compiles on devel (x86)
- no missing, unnecessary BR
- no libs, locales, docs, or need for -devel
- not relocatable
- no duplicate files
- permissions ok
- clean ok
- macro use consistent
- code not content
- nothing in %doc affects runtime
- no need for .desktop
Needswork:
- License is GPL or Artistic, not just Artistic.
- I don't see any reason to conditionalize %check. Just go ahead and run it (and
always use the BR)
- You probably want to use %{perl_vendorlib}/Apache/ instead of
%{perl_vendorlib}/* in %files, otherwise, you won't own the directories that are
created.
Post a fixed spec file and I'll approve this package.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list