[Bug 167820] Review Request: enca - Charset analyzer and discriminator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enca - Charset analyzer and discriminator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167820





------- Additional Comments From ville.skytta at iki.fi  2005-09-08 14:35 EST -------
(In reply to comment #2) 
> > is everything already covered by iconv? 
> Don`t now... 
 
Okay, recode can be enabled later if someone can point out a case where iconv 
isn't up to the task. 
 
> > More docs could be included, for example TODO and ChangeLog* 
> Is it reasonable to include such files for package end-users? It seems to be 
> useful when accompanied with the source code only. 
 
ChangeLog* is not necessary in this case because there's an end user oriented 
NEWS file included, but TODO contains some information about known issues; I 
think people would be interested in that. 
 
> > Test suite not run, could do "make check" in a %check section 
> In your srpm it is "%check || :" -- i.e. depends nothing on it (always 
true)? 
> That what reason to do it? 
 
The "|| :" part is a relic, it is there to support pre-rpm 4.2 versions that 
don't understand the %check _section marker_.  In a more up to date, clean 
specfile that would read: 
 
   %check 
   make check 
 
More info: 
http://rpm.org/max-rpm-snapshot/s1-rpm-specref-scripts.html#S3-RPM-SPECREF-CHECK 
http://rpm.org/max-rpm-snapshot/s1-rpm-inside-scripts.html#S3-RPM-INSIDE-CHECK-SCRIPT 
 
> > --libexecdir=%{_libdir}  
> %configure provides "--libexecdir=%_libexecdir" already... 
 
I know.  That's why I'm overriding it with %{_libdir} (not %{_libexecdir}).  
This is not a blocker but just a note if you want the package's layout closer 
to the FHS. 
 
> > "discriminator" 
> Agree, it is questionable. 
> May be better just: "Character sets analyzer" ? Or "auto-detector"... 
 
Or "Character set detector and converter" 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.