[Bug 167820] Review Request: enca - Charset analyzer and discriminator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: enca - Charset analyzer and discriminator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167820





------- Additional Comments From ville.skytta at iki.fi  2005-09-08 16:51 EST -------
(In reply to comment #4)   
> Using "--libexecdir=%{_libdir}" does not any changes in result.   
   
Hmm, right, that's because you're using %makeinstall which overrides it again.  
BTW, "make install DESTDIR=$RPM_BUILD_ROOT" is generally better than 
%makeinstall; the latter is an ugly hack created for some old config systems 
that don't support sane staged installs using DESTDIR. 
 
 
> New SRPM: http://dmitry.butskoy.name/enca/enca-1.7-2.src.rpm   
   
Unaddressed issue from comment 1:  
- Static libs shouldn't be shipped without a good reason  
http://fedoraproject.org/wiki/PackagingGuidelines#StaticLibraries  
Configuring with --disable-static should work (untested).  
  
  
Build fails, the package insists to install the HTML docs here (and even  
outside of the build root, using "make install DESTDIR=$RPM_BUILD_ROOT"  
instead of %makeinstall would fix that but not the actual issue why the docs  
are installed by "make install" in the first place):  
  Making install in devel-docs  
  make[1]: Entering directory `/home/scop/rpmbuild/BUILD/enca-1.7/devel-docs'  
  make[2]: Entering directory `/home/scop/rpmbuild/BUILD/enca-1.7/devel-docs'  
  make[2]: Nothing to be done for `install-exec-am'.  
  /bin/sh ../mkinstalldirs /usr/share/gtk-doc/html/libenca  
  mkdir /usr/share/gtk-doc/html/libenca  
 mkdir: cannot create directory `/usr/share/gtk-doc/html/libenca': Permission  
denied  
  make[2]: *** [install-data-local] Error 1  
  
  
The availability of external converter programs at build time affects what  
becomes the default external converter.  For reproducible builds, make sure 
that the default becomes consistently the same, eg. add  
"BuildRequires: recode" (assuming we don't have cstocs installed anywhere; it 
is checked before recode by the config system). 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.