[Bug 166188] Review Request: perl-Class-DBI-Loader : Dynamic definition of Class::DBI sub classes
bugzilla at redhat.com
bugzilla at redhat.com
Fri Sep 9 09:57:08 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Class-DBI-Loader : Dynamic definition of Class::DBI sub classes
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166188
paul at city-fan.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |paul at city-fan.org
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From paul at city-fan.org 2005-09-09 05:57 EST -------
Review:
- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions problems
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
- no desktop file needed
Suggestions:
- POD checks are skipped by default - they can be enabled by setting the
TEST_POD environment variable
- Having enabled POD checks, you'll then need to disable the POD coverage
check because it fails
- Additional BR: perl(Test::Pod) is needed for the POD check
- BR: perl(Class::DBI) isn't needed because it's pulled in by the other
BR's that are derived from that class
- Explicit perl(Class::DBI) dep isn't needed because it's pulled in by the
other auto-detected deps (e.g. perl(Class::DBI::SQLite))
Approved since these aren't blockers.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list