[Bug 167755] Review Request: perl-Apache-Session-Wrapper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Apache-Session-Wrapper


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167755


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-12 08:11 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, license text included (from upstream :-))
- spec written in English and is legible
- sources match upstream
- builds OK on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets

Needswork:

- Apache/Session/Wrapper.pm includes:
  use base qw(Class::Container);
  this dep isn't picked up automatically, so it'll need a manual dep.

- Missing BR: perl(Module::Build). Since the package uses Module::Build, it's
  probably best to use Build.PL anyway.

Nitpick:

- Adding BR: perl(Test::Pod) would improve test cover.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.