[Bug 168160] Review request: perl-prefork - Optimized module loading for forking or non-forking processes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-prefork - Optimized module loading for forking or non-forking processes


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168160


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpo at di.uminho.pt  2005-09-12 21:58 EST -------
APPROVED

MD5SUMS:
486eb1f9150572e10ebd9c49908f87ba  perl-prefork-1.00-1.src.rpm

250a0773d5e8b1cfcbb1c776a0462c9b  perl-prefork.spec
41e19e56aca6ae7f36bcbfe420a0eb4c  prefork-1.00.tar.gz


Good:
* Package name follows standard
* Source tarball MD5 digest checked against CPAN
* URL and Source URL are valid
* License verified and included (file LICENSE)
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions are valid
* Builds without problems in FC3 and FC4
* No opened tickets in·
  http://rt.cpan.org/NoAuth/Bugs.html?Dist=prefork


Potential improvements:

* Drop the following BR:

»···BuildRequires: perl(Test::More) >= 0.47
»···BuildRequires: perl(File::Spec) >= 0.80
»···BuildRequires: perl(Scalar::Util) >= 1.10

  As of perl 5.8.1 these core modules have versions equal or superior to
  the ones listed above ($ corelist -a Teste::More File::Spec Scalar::Util)

* Maybe change the description to

»···prefork.pm is intended to serve as a central and optional marshalling
»···point for state detection (are we running in compile-time or run-time
»···mode) and to act as a relatively light-weight module loader.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.