[Bug 166835] Review Request: perl-SNMP_Session - Pure Perl SNMP v1 and SNMP v2 support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SNMP_Session - Pure Perl SNMP v1 and SNMP v2 support


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166835


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-13 06:13 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is Artistic, matches spec, text included
- spec written in English and is legible
- sources match upstream
- packages builds OK on FC4 and in mock for rawhide (i386)
- no explicit BR's needed
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets
- no .desktop file needed

Nitpick:

- redundant BR: perl

- given that "make test" does nothing, it would be nice if someone with
  SNMP-enabled kit could try out some of the test scripts to make sure that
  things work properly...

I'll approve the package but please lose the BR: perl in cvs.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.