[Bug 168194] Review request: perl-ExtUtils-AutoInstall - Automatic install of dependencies via CPAN

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-ExtUtils-AutoInstall - Automatic install of dependencies via CPAN


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168194


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-14 07:27 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- source matches upstream
- package builds OK in mock for FC4 (i386)
- BR's OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets

Needswork:

- license text not included, nor is any comment included in spec about this;
  I suggest adding a comment "# For license text(s), see the perl package" in
  or near the %files list, as in the perl-Hook-LexWrap package (see also
  bug 167405)

- Typo in URL for Source: s/AUTRJIUS/AUTRIJUS/

Comments:

- adding additional BRs of links, wget, ncftp, ftp, and gpg would get rid of
  the warnings produced in "make test" but I don't think it matters really

- it would be nice if the module's ability to install and uninstall other
  modules could be disabled; whilst this is core functionality for the module,
  it's not really desirable behaviour on an RPM-based system, where I guess
  the purpose of this module is only really as a version-checker for other
  module builds (this is probably not possible though)



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.