[Bug 166254] Review Request: perl-Imager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Imager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166254





------- Additional Comments From jspaleta at gmail.com  2005-09-14 20:37 EST -------
Okay let me go through the full review now.  
builds in mock for fedora development on x86.

*naming is good
*perl specific spec file conventions are being used
*license tag matches the wording in the readme
*readme with licensing terms include in docs
*md5sum of sources match upstream
*rpmlint returns clean
*buildrequires look good, all the supprted image and font support appears to be
included at build time according to the build log. 
*no locale files to worry about
*no shared libraries in the linker path
*created directory ownership is good
*clean section good
*no pre/post scriptlets 
*no static libs
*files section looks good
*no executables installed
*no executables in docs section 
*rpmbuild --rebuild --target i686 works 
*sample scripts appear to work.. no errors or segfaults.

Okay this looks good to me. I'll start the clock on this. I'll wait 24 hour
before approving this in case someone finds a blocker.

-jef



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.