[Bug 168178] Review request: perl-Class-Autouse - Run-time class loading on first method call

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-Class-Autouse - Run-time class loading on first method call


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168178


jpo at di.uminho.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |jpo at di.uminho.pt
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From jpo at di.uminho.pt  2005-09-14 21:42 EST -------
APPROVED

MD5SUMS:
af80dc0e4737a00fead18380c70fa3ca  perl-Class-Autouse-1.20-1.src.rpm

746a4f415dd8c7267bcec07841022275
746a4f415dd8c7267bcec07841022275  Class-Autouse-1.20.tar.gz
c16f62a4fffa4b45795b3eb9308f6ff5  perl-Class-Autouse.spec

Good:
* Package name follows standard
* Tarball MD5 digest verified against CPAN copy
* URL and Source url are valid
* License verified and included
* perl(:MODULE_COMPAT_xxx) present
* perl vendor libs present
* File permissions are valid
* Builds without problems in FC3 and FC4


Potential improvements:

* add the optional build requirement: perl(prefork)
    ...
    t/03_prefork......skipped
        all skipped: prefork.pm is not installed
    t/04_recursive....ok
    ...

    Please add at least this one after importing the package to CVS.

* drop the README file (same content as in the main POD document)

* drop the following superflous build requirments (since perl 5.8.1 at least):

    BuildRequires: »···perl(Test::More) >= 0.47
    BuildRequires: »···perl(File::Spec) >= 0.82
    BuildRequires: »···perl(List::Util) >= 1.11



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.