[Bug 165407] Review Request: srecord - Manipulate EPROM load files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: srecord - Manipulate EPROM load files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165407


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2005-09-14 22:00 EST -------
Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

NEEDSWORK:

Source does NOT match upstream:

md5sum srecord-1.22.tar.gz rpmbuild/SOURCES/srecord-1.22.tar.gz
d67c70be352486db6a9c0929a4d8f08e  srecord-1.22.tar.gz
01ee85525efd8bbbec9b80ddec44576d  rpmbuild/SOURCES/srecord-1.22.tar.gz

Minor nitpick:

make could use %{?_smp_mflags}.

Fix the source to match upstream, and I'll recheck.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.