[Bug 168175] Review request: perl-Algorithm-Dependency - Algorithm::Dependency Perl module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-Algorithm-Dependency - Algorithm::Dependency Perl module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168175


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-15 07:50 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock on FC4 (i386)
- BR's mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- no large docs
- docs don't affect runtime
- code, not content
- no desktop file needed
- no scriptlets

Needswork:

- URL for Source0 doesn't work: s/www/search/
- should BR: perl(Params::Util) version 0.05, not version 0.5

Nitpick:

- last changelog entry should be "Thu Sep 15", not "Tue Sep 15"
- add BR: perl(Test::Pod) for better test coverage


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.