[Bug 168187] Review request: perl-File-Flat - Implements a flat filesystem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review request: perl-File-Flat - Implements a flat filesystem


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168187


paul at city-fan.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |paul at city-fan.org
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From paul at city-fan.org  2005-09-19 08:05 EST -------
Review:

- rpmlint clean
- package and spec naming OK
- license is same as perl, matches spec, text included
- spec file written in English and is legible
- source matches upstream
- builds OK in mock for FC4 (i386)
- BR's look OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no duplicate files
- no directory ownership or permissions issues
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop file needed
- no scriptlets

Query:

- where did the specific version dependencies for File::Copy, File::Find and
  IO::File come from? Makefile.PL just seems to check for *any* version of
  these modules rather than specific versions

Approved.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.