[Bug 168920] Review Request: xml-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xml-utils


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168920





------- Additional Comments From bdpepple at ameritech.net  2005-09-23 15:36 EST -------
PUBLISH +1, once package naming issue resolved.

MD5Sums:
ffd80f1fda6ecdd1f85bd88d87a0d2e7  html-xml-utils-3.7.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* All directories are owned by this or other packages
* All necessary BuildRequires listed.
* All desired features are enabled
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Package installs and uninstalls cleanly on FC4
* Software runs fine

Bad:
* Is there any reason why the package name doesn't follow the upstream tarball
name?  Based on a quick Google search, every other rpm package I could find
follows the upstream tarball.

Minor:
* The NEWS file shouldn't be packaged, since it's empty.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.