[Bug 168523] Review Request: perl-Text-Diff

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 27 12:32:24 UTC 2005


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Text-Diff


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168523


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-09-27 08:32 EST -------
Review for release 2:
* RPM name is OK
* Source Text-Diff-0.35.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint of perl-Text-Diff looks OK
* File list of perl-Text-Diff looks OK
* Works fine

Possible improvements:
The fedora spec template for perl modules uses this in %build:
  CFLAGS="$RPM_OPT_FLAGS" %{__perl} Makefile.PL INSTALLDIRS=vendor
  make %{?_smp_mflags} OPTIMIZE="$RPM_OPT_FLAGS"
These optimizations could be added.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the fedora-extras-list mailing list