[Bug 169361] Review Request: nautilus-image-converter
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 27 15:40:52 UTC 2005
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: nautilus-image-converter
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169361
tcallawa at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|gdk at redhat.com |tcallawa at redhat.com
OtherBugsDependingO|163776 |163779
nThis| |
------- Additional Comments From tcallawa at redhat.com 2005-09-27 11:40 EST -------
Good:
- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Needswork:
- needs to own the %{_datadir}/%{name}/ directory.
You can fix this by changing:
%{_datadir}/%{name}/nautilus-image-resize.glade
to
%{_datadir}/%{name}/
As this is a minor touchup, I'm approving this package, but please make this
change before building.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the fedora-extras-list
mailing list