[Bug 187818] Review Request: ktorrent : KDE bittorrent client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ktorrent : KDE bittorrent client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187818


rdieter at math.unl.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter at math.unl.edu




------- Additional Comments From rdieter at math.unl.edu  2006-04-03 15:45 EST -------
Off the top of my head:

* use --vendor='' instead of --vendor="fedora", as the .desktop file already has
a vendor of 'kde'

* See "GTK+ icon cache" in
  http://fedoraproject.org/wiki/ScriptletSnippets

* If the .desktop file contains a MimeType= entry, see "desktop-database" on
same ScriptletSnippets page.

* See "Exclusion of Static Libraries" on
http://fedoraproject.org/wiki/Packaging/Guidelines regarding libtool archives. 
In short, you want to delete/omit
%{_libdir}/lib*.la

* The %{_libdir}/kde3/* bits should be in the main pkg, not -devel

* actually, since the only thing that's going to end up in -devel is
%{_libdir}/lib*.so, there's probably not much point in even making a -devel
subpkg.  Might as well fold everything into the main pkg.

* Not much point in including
%doc INSTALL
Since that's (usually) talks about compiling/building, and installing from
source, which isn't relevent here.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.