[Bug 187980] Review Request: cdogs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cdogs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187980


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wart at kobold.org




------- Additional Comments From wart at kobold.org  2006-04-04 22:53 EST -------
A few quick notes:

Please use the full url to the downloadable source archive in the Source0: tag.

BuildRoot should match the Fedora Packaging Guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines

There's a typo in teh smp_mflags:  ) should be _

Use 'install -m ...' instead of 'mv' when copying files to /usr/bin so that you
can explicitly set the permissions.

Remove the leading 'a' and trailing period from the Summary.

Uncomment the 'rm' command in %clean.  Make sure you have the same rm command at
the start of the %install section.

Doesn't build on x86_64:

+ make
gcc -O2 -march=pentium2 -mtune=pentium2 -ggdb -Wall `sdl-config --cflags`
-I./include -I./missions \
-DCDOGS_DATA_DIR=\"/usr/local/share/games/cdogs/\" -c cdogs.c
cdogs.c:1: error: CPU you selected does not support x86-64 instruction set
cdogs.c:1: error: CPU you selected does not support x86-64 instruction set
make: *** [cdogs.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.74551 (%build)

In general, it looks like you should go over the packaging guidelines (linked
above) again and make sure that your spec file conforms to the Fedora Extras
standards.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.