[Bug 177277] Review Request: perl-SQL-Abstract-Limit : Portable LIMIT Emulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SQL-Abstract-Limit : Portable LIMIT Emulation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177277


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-04-07 16:25 EST -------
The package builds cleanly and rpmlint is silent.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   127285b0a59f2a671fd4c411371d4877  SQL-Abstract-Limit-0.12.tar.gz
   127285b0a59f2a671fd4c411371d4877  SQL-Abstract-Limit-0.12.tar.gz-upstream
* package builds in mock.
* BuildRequires are proper.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/SQL, which will probably also be owned by
any module under the SQL:: namespace.  However, none of the dependencies create
this directory so there is no alternative but for this package to own it.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.