[Bug 188309] Review Request: conserver - serial console server daemon/client

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 7 20:34:25 UTC 2006

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conserver - serial console server daemon/client


tcallawa at redhat.com changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |tcallawa at redhat.com
OtherBugsDependingO|163776                      |163779
              nThis|                            |

------- Additional Comments From tcallawa at redhat.com  2006-04-07 16:34 EST -------
- rpmlint checks return: nothing!
- package meets naming guidelines
- package meets packaging guidelines
- license (Distributable, BSD/MIT-ish, same as libtabe) OK, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

One minor note: It would be nice to see LICENSE included as %doc before commit.
Otherwise, this is great. Approved.

Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

More information about the fedora-extras-list mailing list