[Bug 187313] Review Request: perl-Authen-Radius

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Authen-Radius


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187313





------- Additional Comments From tibbs at math.uh.edu  2006-04-07 21:14 EST -------
I'm not a Radius user but I can do a review.  The package builds fine in mock
(devel branch) and rpmlint is silent.

Issues:
BuildRequires: perl is not allowed; cpanspec should be able to generate a proper
specfile that doesn't do this.
There's no point in the BuildRequires: for perl(IO) and perl(Digest::MD5) as
these are part of base perl, but I don't supposed there's any harm in keeping
them.  The only thing that's strictly necessary is
BuildRequires: perl(Data::HexDump)

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   8427f931a4e0e689ecf8ddf30e5a0ea7  RadiusPerl-0.12.tar.gz
   8427f931a4e0e689ecf8ddf30e5a0ea7  RadiusPerl-0.12.tar.gz-srpm
* package builds in mock.
X BuildRequires: perl not permitted.
* no shared libraries.
* package is not relocatable.
* owns the directory it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/Authen, which will probably also be owned
by any module under the Authen:: namespace.  However, there are no dependencies
which could create this directory so there is no alternative but for this
package to own it.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.