[Bug 188378] Review Request: perl-Test-NoWarnings
bugzilla at redhat.com
bugzilla at redhat.com
Mon Apr 10 00:43:44 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Test-NoWarnings
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188378
tibbs at math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs at math.uh.edu 2006-04-09 20:43 EST -------
Builds fine in mock (development branch, with dependencies added) and rpmlint is
silent.
Issues:
For grammar's sake, s/modules/module/ in the description.
Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible. Text of license is included in the package.
* source files match upstream:
702143eab77ffc335a08beccac47dca4 Test-NoWarnings-0.082.tar.gz
702143eab77ffc335a08beccac47dca4 Test-NoWarnings-0.082.tar.gz-srpm
* package builds in mock.
* BuildRequires are proper.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
* The package owns %{perl_vendorlib}/Test, which is also owned by other modules
in the Test:: namespace. No dependency owns this directory, however, so there's
no alternative.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list