[Bug 185721] Review Request: yadex - Doom level/wad editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yadex - Doom level/wad editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185721


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-04-10 05:55 EST -------
I just saw I already started a full review, so its easy to finish it here we go
again:

MUST
====
* rpmlint output OK:
E: yadex configure-without-libdir-spec
W: yadex patch-not-applied Patch1:
http://glbsp.sourceforge.net/yadex/Yadex_170_Hexen.diff
Which are both ok, for the patch warning see the comment in the spec file, the
other is no problem since there are no files installed to %{_libdir} and there
is a good reason to not use %configure (see comment in spec)
* Package named correctly
* GPL license OK.
* spec file legible, in Am. English
* Source matches upstream
* Successfully compiles and builds on at least one platform (devel x86_64 & i386)
* no locale data, shared libraries, or static libraries
* No excessive Requires: or BR:
* Summary and description ok
* macro use consistent
* package owns the directories that it creates.
* Not relocatable
* %doc does not affect runtime

Approved!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.