[Bug 188400] Review Request: ssmtp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ssmtp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188400





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-04-11 07:53 EST -------
* the ugly CPP flag check can be probably expressed simply as

  | BuildRequires: krb5-devel  # (perhaps implicated by openssl-devel in RHEL3)
  | ...
  | test -e /usr/include/krb5.h || CPPFLAGS='-I/usr/include/kerberos'


* the 'Provides: smtpdaemon' is right; afais, it is used by other
  packages to express a requirement on a sendmail compatible CLI
  tool. Interpreting it as something which listens on a TCP port does
  not make sense because the daemon might be running on another host
  which can not be controlled by the local package-manager

* sometimes ago, I packaged ssmtpd myself. In this package, the
  %install section was shorter:

  | %install 
  | rm -rf $RPM_BUILD_ROOT 
  | %makeinstall etcdir='$(sysconfdir)' GEN_CONFIG=/bin/true mandir="$RPM_BUILD_ROOT%_mandir/man8" 
  | install -p -m644 ssmtp.conf $RPM_BUILD_ROOT%_sysconfdir/ssmtp/ssmtp.conf 

  I does not include your alternatives symlinks but is nevertheless a
  little bit shorter.

* not a blocker on Fedora, but using '/sbin/update-alternatives'
  instead of '/sbin/alternatives' is more portable across the various
  Linux distributions.

* I would not Provide: the man-pages; it is error-prone (see your
  'man5/ssmtp.conf.5' entry) and you can not control how 'rpmbuild'
  packages them finally (perhaps bz2-packed or plain instead of
  gzip-packed)

* I think, a real name would help significantly in getting a sponsor...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.