[Bug 187304] Review Request: echoping latency meassure tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: echoping latency meassure tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187304


fedora.wickert at arcor.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From fedora.wickert at arcor.de  2006-04-13 09:15 EST -------
(In reply to comment #4)  
> > - SHOULD: make macro usage more consistent: Please use $RPM_BUILD_ROOT instead
> > of %{buildroot}
> According to the guidelines, either one is okay.

Yes, but %{buildroot} only should be used in %install (or %clean). If for some
reason you need it in %configure you'll have to use $RPM_BUILD_ROOT there. Your
macro usage would become inconsistent then, since you are using two different
macros for the same thing. Nevertheless this isn't a blocker.

md5sum echoping-5.2.0-1.src.rpm
da157ff97fc7de0d9aabb6bd64027702  echoping-5.2.0-1.src.rpm

The new package addresses all outstanding issues:
- license ok
- license included in source and correctly installed in %doc
- license field in spec matches actual license
- package versioning fixed
- %defattr fixed
- %doc section correct, no superflurious or empty files
- changelog fixed
- all other items are ok as described in comment #1

ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.