[Bug 187317] Review Request: mindi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mindi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187317


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |gauret at free.fr
                 CC|gauret at free.fr              |
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2006-04-17 12:28 EST -------
Needs work :
* No need to define all tags at the top of the spec file. Just use the rpm tags,
that will define the proper variables.
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n) (wiki: PackagingGuidelines#BuildRoot)
* Non standard group Archiving/Archiving (you can use Applications/Archiving)
* Some paths are not replaced with RPM macros (wiki: QAChecklist item 7) (in the
scriptlet)
* No downloadable source. Please give the full URL in the Source tag.
* The BuildRoot must be cleaned at the beginning of %install, not in %prep (it
breaks rpmbuild --short-circuit)
* The build should be done in %build, and only the install in %install (as a
result, you can't use the install.sh script)
* The scriptlets should never output anything. It can break some graphical
installers, and installation can be unattended.
* The /etc/mindi directory is not owned
* File list: some files were listed multiple times
  (wiki: Packaging/ReviewGuidelines) : %{_libdir}/mindi is recursive, you'd
better set the correct mode in %install and get rid of the last 3 lines of the
%files section.
* You need to add a changelog entry

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.