[Bug 188105] Review Request: torque

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: torque


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188105





------- Additional Comments From garrick at usc.edu  2006-04-17 15:30 EST -------
(In reply to comment #12)
> nits:
>  - the [ "$RPM_BUILD_ROOT" != "/" ] is not necessary for FE

Ok, will remove.

>  - If you'd like to have the same version of torque in, say, 
>      FE4, FE5, and devel then you'll probably want to add
>      %{?dist} per http://fedoraproject.org/wiki/DistTag

I was wondering about this, but I left it out because it isn't actually in the
naming guidelines.

>  - perhaps the headers currently located at /usr/include/* 
>      could go in a subdir such as /usr/include/torque/* since 
>      some of the header files have rather unfortunately generic 
>      names (eg. "tm.h")

Sure.
 
> blockers:
>  - How can I verify that the source matches upstream?  I found 
>    the download pages at:
> 
>      http://www.clusterresources.com/downloads/torque/snapshots/
> 
>    but I can't seem to find the same .tar.gz file or a way to 
>    create an identical one from CVS -- could you please document 
>    that step within the spec file as a comment so that I can repeat 
>    it?  Or perhaps use one of the "official" tar files?

I'll roll an "official" snapshot upstream and give you a new srpm in a few minutes.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.