[Bug 172872] Review Request: sloccount

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sloccount


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172872


ed at eh3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gdk at redhat.com              |ed at eh3.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ed at eh3.com  2006-04-03 13:36 EST -------
Hi Bastien,

The above SRPM URL gave a 404 but I found the "-2" rev which I assume
you meant to reference in the first place.

36397816454626ed4abc11afc66783aaec01f444  sloccount-2.26-2.src.rpm

good:
 - source matches upstream
 - builds on FC4 i386 (still waiting on the mock build...)
 - rpmlint OK -- no warnings or errors
 - name OK
 - license is OK and correctly included
 - spec-file is clean and simple (although it might be 
     nice to use "%setup -q" but thats just a suggestion!)
 - no shared libs
 - dir ownership and permissions OK

very minor nit:
 - the description could be shortened a bit and the text 
     better formatted -- but thats not a blocker

Its taking me a while to get a mock build and I think its due to a 
slow network connection.  As soon as I get a clean mock build, I'll 
approve the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.