[Bug 175631] Review Request: fedora-package-config-smart - Configuration files for the smart package manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: fedora-package-config-smart - Configuration files for the smart package manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175631


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
         AssignedTo|Jochen at herr-schmitt.de      |tcallawa at redhat.com
OtherBugsDependingO|                            |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2006-04-09 19:16 EST -------
Review:

- rpmlint checks return:
E: fedora-package-config-smart no-binary
W: fedora-package-config-smart no-documentation

Both are safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK
- spec file legible, in am. english
- no real way to check config files against "upstream"
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- content ok
- no need for -docs
- nothing in %doc
- no need for .desktop file 

APPROVED. One down, one to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.