[Bug 175630] Review Request: smart - Next generation package handling tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: smart - Next generation package handling tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175630


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
         AssignedTo|gdk at redhat.com              |tcallawa at redhat.com
OtherBugsDependingO|                            |163778
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2006-04-09 19:51 EST -------
One minor issue that I see immediately: 
smart should have Requires: fedora-package-config-smart

Review:
- rpmlint checks return:
W: smart-update no-documentation (ok to ignore)
W: smart-gui conffile-without-noreplace-flag /etc/pam.d/smart-root 
W: smart-gui conffile-without-noreplace-flag /etc/security/console.apps/smart-root
(ok to ignore, there should be no need for the user to edit these files)
W: smart-gui no-documentation (ok to ignore)

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file ok 

Minor issues:

- There is one reference to /usr/bin , please replace with %{_bindir}

Major Issue:
- gui mode doesn't work with the included distro.py. You need to make the
following change:

--- distro.py.orig      2006-04-09 18:56:29.000000000 -0500
+++ distro.py   2006-04-09 18:56:48.000000000 -0500
@@ -6,9 +6,9 @@
                      "name": "RPM Database"})

     for flavour in ("", "-smp", "-hugemem", "-largesmp", "-xen0", "-xenU",
"-kdump"):
-        pkgconf.setFlag("multi-version", "kernel%s" flavour)
-        pkgconf.setFlag("multi-version", "kernel%s-unsupported" flavour)
-        pkgconf.setFlag("multi-version", "kernel%s-devel" flavour)
+        pkgconf.setFlag("multi-version", "kernel%s" % (flavour))
+        pkgconf.setFlag("multi-version", "kernel%s-unsupported" % (flavour))
+        pkgconf.setFlag("multi-version", "kernel%s-devel" % (flavour))
         for clustergfs in ("GFS", "cman", "dlm", "gnbd"):
              pkgconf.setFlag("multi-version", "%s-kernel%s" % (clustergfs,
flavour))

... otherwise, it gets confused in trying to call setFlag, this resolves it.

Show me a package that has all of these items resolved, and I will approve it.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.