[Bug 188458] Review Request: libassetml - xml resource database library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libassetml - xml resource database library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188458


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-04-13 01:08 EST -------
rpmlint output:
E: libassetml-debuginfo script-without-shellbang
/usr/src/debug/libassetml-1.2.1/src/tools/assetml-query.c

MUST
====
* Package and spec named appropriately
* GPL license ok.  License file included in base package
* Spec file legible and in Am. English
* Source matches upstream
  4b10fd0fb8e00a4fb526665413479516  libassetml-1.2.1.tar.gz
* Compiles and builds on FC-4 i386, FC-4 x86_64
* No excessive or disallowed BR:
* Locales handled correctly
* ldconfig called in %post/%postun correctly
* Not relocatable
* No duplicate %files
* build root cleaned in %clean and at start of %install
* headers, pkgconfig files, and unsuffixed shlib in -devel
* -devel requires base
* No .la archives
* No .desktop file necessary
* Contains code, not content

SHOULDFIX
=========
* This isn't a blocker, but you can get rid of the rpmlint warning by
  removing the execute permission bit on the offending source file in %prep.

* -devel owns %datadir/gnome.  However, it seems that almost 20 other packages
  also claim to own this directory, so this isn't a blocker.  Perhaps you
  can restrict the ownership to %datadir/gnome/help/%name?

Since there are no blockers, consider this APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.