[Bug 188351] Review Request: gphpedit - GNOME2 PHP editor
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 13 22:45:39 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gphpedit - GNOME2 PHP editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188351
fedora.wickert at arcor.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|bugzilla-sink at leemhuis.info |fedora.wickert at arcor.de
OtherBugsDependingO|163776 |163778
nThis| |
------- Additional Comments From fedora.wickert at arcor.de 2006-04-13 18:45 EST -------
Hi Tim, just a few comments:
- Source0 needs an absolute URL like http://...
- The %files section looks broken, the package doesn't own %{_datadir}/gphpedit/.
- You are replacing a hardcoded path with another hardcoded one in the specfile.
Better use
sed -i s_/usr/local/share/pixmaps_%{_datadir}/pixmaps_ src/main.h
- Please add the categories "GNOME" and "Application" to gphpedit.desktop
The rest looks good to me. I'm going to do a review ASAP.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list