[Bug 187430] Review Request: elektra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430





------- Additional Comments From pertusus at free.fr  2006-04-14 09:06 EST -------
(In reply to comment #3)
> But with the changelog, I meant a changelog for the package. So for now, only a
> 'Initial build' would be enough, something like this:
> ----------
> * Fri Mar 31 2006 Avi Alkalay <avi at unix.sh> 0.6.0-0.1
> - Initial build.
> ----------

Agreed.


> In the buildrequires section you have db4-devel. Are you sure that the berkeley
> sub-package doesn't need db4 to work? And GConf2 and libxml?

These should be picked up automatically by rpm.
 
> Further, you're using $RPM_BUILD_ROOT, please change those in %{buildroot}

It is not required to use one or the other form, as long as the use
of one or the other is consistent (and consistent with the optflags).

> and I'm not sure, but I thought that calling /sbin/ldconfig wasn't necessary.

As there are some dynamic libs installed, the ldconfig call is
necessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.