[Bug 187430] Review Request: elektra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430





------- Additional Comments From avi at unix.sh  2006-04-16 06:35 EST -------
(In reply to comment #12)
> > > > > * DTDVERSION isn't usefull
> Why?

OK. Hardcoded later.



> There is still one left:
> mv $RPM_BUILD_ROOT/%{_lib}/libelektra.a $RPM_BUILD_ROOT/usr/lib

Fixed.


> Ok. libelektra.so should be in a development package, however.

It is as /usr/lib/libelektra.a
I'm not sure I understand this. Are you saying that libelektra.so must be 
duplicated in the -devel and main package ?



> libelektra_berkeleydb_la_LDFLAGS = -avaoid-version -module

Thanks for this tip !



> It would even be better to install the backend libraries in a specific
> directory (say /lib/elektra-backends/, with the help of a backenddir
> automake varialbe) and use lt_dlsetsearchpath.

We'll think about it in next versions.


> > The correct URL is
> > http://prdownloads.sourceforge.net/elektra/%{name}-%{version}.tar.gz
> > We re working with the development version, which is not in SF. Use this
> > instead:
> > 
> > http://avi.alkalay.net/software/elektra/
> 
> No. We want to avoid using private source when public sources exist.
> Indeed we cannot review all the sources so we rely on public sources
> having been reviewed.

The correct URL is being used. I gave you my private one just for your test.
Please download the update for your new test again from the private URL.



> I am not opposed to having a comment like this one:
> 
> # to rebuild from cvs you need:
> # automake autoconf libtool gettext-devel

OK, they are just comments now.



> In fact it is not ;-). The backend-berkeleydb is dlopened so
> no need for ldconfig call.

Thats right. Removed.




> What about
> %configure --libdir=/%{_lib} \
>      --bindir=/bin \
>      --disable-xmltest \
>      --with-docbook=%{_datadir}/sgml/docbook/xsl-stylesheets

Thanks !



> > > * the %post action should only be done for the first install?
> > 
> > Yes, it is correct this way.
> 
> I don't really understand your answer, but my question was not a
> well formulated question ;-). So here it is:
> 
> Should the following 2 commands be run only for the first 
> installation?
> kdb set -t dir system/sw
> kdb set system/sw/kdb/schemapath
> "%{_datadir}/sgml/elektra-%{DTDVERSION}/elektra.xsd"

They must be executed on every install, upgrade, etc because we want to set 
the correct DTD version being installed. So there is no need to test if we are 
in a fresh installation or upgrade with a `if [ $1 -eq 0 ]; then`



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.