extras-buildsys/utils extras-sign-move.py,1.11,1.12
seth vidal
skvidal at linux.duke.edu
Sun Apr 23 19:00:36 UTC 2006
On Sun, 2006-04-23 at 21:55 +0300, Ville Skyttä wrote:
> On Sun, 2006-04-23 at 11:40 -0700, Seth Vidal wrote:
>
> > Modified Files:
> > extras-sign-move.py
> > Log Message:
> >
> > if the file already exists, unlink it - this lets us sneak out silent
> > changes
> [...]
> > if not DEBUG:
> > + if os.path.exists(rpmloc):
> > + os.unlink(rpmloc)
> > shutil.copy2(package, rpmloc)
>
> Eh... rationale? We should be making sure that this _cannot_ happen,
> not make it easier or automatic.
in this specific case I added it b/c some num-num updated their packages
w/o iterating the release. So we ended up with a conflict. If you'd like
to reverse it - so that we trust the repo over the just-built - that's
fine - just make it:
if os.path.exists(rpmloc):
os.unlink(package)
then skip the shutil.copy2()
that'll work just as well, though, to be clear - I think it would be
handy to be able to overwrrite a change.
-sv
More information about the fedora-extras-list
mailing list