[Bug 180205] Review Request: gnome-menu-editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-menu-editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180205





------- Additional Comments From wart at kobold.org  2006-02-06 14:37 EST -------
A couple of comments (this is not a formal review):

* Don't use the name/version/release defines at the top of the file.  Set the
values explicitly in the Name:, Version:, and Release: fields.  These implicitly
define %{name}, %{version}, and %{release} macros.

* Be consistent with your use of $RPM_BUILD_ROOT and %{buildroot}.  They both
evaluate to the same value.  Use one or the other in your specfile, but not both.

* Don't use the Package and Vedor tags, per the FE packaging guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.