[Bug 180299] Review Request: pitivi

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pitivi


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180299


jeff at ollie.clive.ia.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |jeff at ollie.clive.ia.us




------- Additional Comments From jeff at ollie.clive.ia.us  2006-02-07 00:13 EST -------
1. Eliminate the various %defines at the beginning of the spec 
2. Use "make DESTDIR=$RPM_BUILD_ROOT install" instead of %makeinstall
3. Use -p when manually calling install
4. Need to BuildRequire: gnonlin-devel
5. Need to Require: gnonlin
6. Use desktop-file-install to install .desktop file.  See:
<http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755>
7. BuildArch: noarch
8. %files section probably would work better as follows.  That way the .pyo
files aren't packaged, but will be removed when the
packags is uninstalled.

%{_bindir}/pitivi
%dir %{_libdir}/pitivi
%dir %{_libdir}/pitivi/python
%dir %{_libdir}/pitivi/python/pitivi
%{_libdir}/pitivi/python/pitivi/*.py
%{_libdir}/pitivi/python/pitivi/*.pyc
%ghost %{_libdir}/pitivi/python/pitivi/*.pyo
%dir %{_libdir}/pitivi/python/pitivi/ui
%{_libdir}/pitivi/python/pitivi/ui/*.py
%{_libdir}/pitivi/python/pitivi/ui/*.pyc
%ghost %{_libdir}/pitivi/python/pitivi/ui/*.pyo
%{_datadir}/pitivi
%{_datadir}/applications/pitivi.desktop

9. I could get pitivi to run, but couldn't seem to get it to do much.
10. Eliminate period at end of summary.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.