[Bug 181534] Review Request: kst - plots scientific data

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kst - plots scientific data


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181534





------- Additional Comments From orion at cora.nwra.com  2006-02-17 16:23 EST -------
Needs work:
* Use of buildroot is not consistant
  (wiki: PackagingGuidelines#UsingBuildRootOptFlags)
  = sorry - this was introduced by my ln suggestion (I use RPM_BUILD_ROOT
instead of %buildroot).  You might try:

for x in %{buildroot}%{_defaultdocdir}/HTML/*/%{name}/
do
  ln -sf ../common $x
done

Will handle any new languages automatically in the future.  I think the dangling
link for other languages is fine.


- You need to install the .desktop file properly.  See
http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28.desktop%29#head-254ddf07aae20a23ced8cecc219d8f73926e9755
I would also use --delete-original to remove the original.  The
Applications/Scientific directory structure is not used in Fedora.  e.g. (from
my kdesvn package):

desktop-file-install --vendor=fedora \
       --add-category=Qt \
       --add-category=KDE \
       --add-category=Application \
       --add-category=Development \
       --add-category=X-Fedora \
       --delete-original --dir $RPM_BUILD_ROOT%{_datadir}/applications \
       $RPM_BUILD_ROOT%{_datadir}/applications/kde/%{name}.desktop



I think that may be it :-)!



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.