%{SOURCEn} versus $RPM_SOURCE_DIR

[Rex Dieter]

Jason L Tibbitts III wrote:
>>>>>> "IV" == Ignacio Vazquez-Abrams <ivazquez at ivazquez.net> writes:
> 
> IV> %{SOURCE1} will always refer to Source1 regardless of what "blah"
> IV> may be. It's also more concise.
> 
> That I agree with, but I guess what I'm really asking is whether use
> of $RPM_SOURCE_DIR is any kind of impediment to package acceptance.
> I'm reviewing a package that uses it and frankly I hadn't seen it
> before.  The wiki has no info.

I can't think of any legitimate use of $RPM_SOURCE_DIR, so IMO, it's use
ought to at least be discouraged (unless there is some unknown good
reason otherwise)

-- Rex