[Bug 182415] Review Request: man-pages-uk - Ukrainian man pages from Linux Documentation Project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: man-pages-uk - Ukrainian man pages from Linux Documentation Project


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182415





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-02-24 18:44 EST -------
Just a couple of quick comments

1. Why the need to change the name to remove the -utf8? I can't recall seeing
anything in the FE rules over that

2. {buildroot} should really be ${RPM_BUILD_ROOT}

3. INSTALLPATH - should that not be DESTDIR?

4. Do you need to include the epoch? It can be more of a pain than anything
(well, from what I've seen of it).

Other than that, it looks okay. I'm not happy with the naming scheme - Release:
0.1%{?date:.%{date}wiki}%{?dist} seems somewhat long (to me). Can you not just have

Release:0.1%{?dist}. I would normally reserve the longer release if the source
was dragged from cvs/svn

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.