[Bug 179758] Review Request: Eiciel (ACL editor)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Eiciel (ACL editor)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=179758





------- Additional Comments From paul at city-fan.org  2006-02-03 09:55 EST -------
(In reply to comment #5)
> I presume that because %doc matches all the files under /usr/share/doc it's best
> to remove my (currently commented) %{_datadir}/doc/eiciel*/*

Yes.

> Similarly I believe that RPM is clever enough to work out the Requires: for
> itself, so my commented Requires: should be removed too? Or if it's not so
> clever as I've assumed I should check more closely the actual Requires:

Look at the dependencies of your built package:

$ rpm -qp --requires /path/to/eiciel*.x86_64.rpm

There should be dependencies for the required shared libraries, normally
satisfied by the libacl, libattr, and gnome-vfs2 packages, so there should be no
need to explictly require these packages.

> I only get a -debuginfo package produced on x86_64, does that indicate a problem?

Maybe you don't have redhat-rpm-config installed on your i386 system?

> All files refreshed to http://adslpipe.co.uk/fedora/extras/eiciel
> 
> I think I should go through a typical review checklist in a "muttering to
> myself" fashion ...

That's always a good idea.

http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.