[Bug 180422] Review Request: gnome-mud

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-mud


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180422





------- Additional Comments From bdpepple at ameritech.net  2006-02-08 19:04 EST -------
Some thing that you need to fix:

1.  There's a couple of unnecessary BR, such as vte, libglade2.
2.  Drop the requires on gtk2.  Your BR should pull this in automatically.
3.  You need to use macros in your file section (and also when you modify the
desktop file).  Refer to the wiki for the specific macros.
4.  Run rpmlint on your rpm.  I'm guessing that it will give a few error that
need to fix (just by looking at your spec I'd say that some of the lines in the
description are to long).
5.  In the files section, /usr/share/* (which should be %{_datadir}, BTW) should
be changed, using a wildcard to pull child directories could cause ownership
problems.
6.  The desktop file looks to be wrong in the files section, since your adding a
vendor.  The file should be fedora-gnome-mud.desktop.  I'm guessing your packing
the wrong desktop file, since your not deleting the original.

You should give the wiki another read-over, since most of the issues are
addressed there.  Before someone will sponser you, you've got to demonstate a
good understanding of Fedora Extras package process and requirements.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.