[Bug 172755] Review Request: xcompmgr - X11 composite manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xcompmgr -  X11 composite manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=172755


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |kevin at tummy.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From kevin at tummy.com  2006-02-12 14:15 EST -------
Greetings, heres a review:

MUST items:

OK - package name good.
OK - spec file matches.
OK - spec in english.
OK - spec legible.
OK - md5sum matches:
44ccbafa8484b7e0c00e5c83cd915adc  xcompmgr-1.1.3.tar.gz
44ccbafa8484b7e0c00e5c83cd915adc  xcompmgr-1.1.3.tar.gz.1
OK - compiles and builds under devel.
OK - files and dirs ok.
OK - clean section good.
OK - macros good.
OK - builds ok in mock on devel.

Needs looking at:

1. License. Is it really X11/MIT? I see that SuSE ships this package as GPL.
The License at the top of the .c file does look BSDish. Might confirm?

2. rpmlint has some output:

E: xcompmgr description-line-too-long xcompmgr is a sample compositing manager
for X servers supporting the XFIXES, DAMAGE, and COMPOSITE extensions. It
enables basic eye-candy effects
W: xcompmgr invalid-license MIT/X11
W: xcompmgr-debuginfo invalid-license MIT/X11

You might add a line break or two in the description line.

Optional:

3. You might optionally ship the Changelog file as a doc.

4. You might get upstream to ship a copy of it's license with it.

Clarify and confirm the License and fix the description line,
and I will APPROVE.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.