[Bug 181599] Review Request: gallery: web based photo album software
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 15 16:15:16 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gallery: web based photo album software
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181599
------- Additional Comments From bugs.michael at gmx.net 2006-02-15 11:15 EST -------
"URL" tag for the web page, "Source" for the tarball download location.
> %defattr(-,root,root-)
Typo. There is no system group "root-". You want "root".
> %{installprefix}/gallery2/*
With that, directory "gallery2" is not included. To include the directory
and everything in it recursively, use just:
%{installprefix}/gallery2/
> I made this package relocatable, as it is intended upstream to
> be installable to a ~/public_html directory as well as /var/www/html,
Questionable. The package has several dependencies. A normal user with
an own RPM database could not simply install the package without using
the --nodeps option.
> %install
> [ "${RPM_BUILD_ROOT}" != "/" ] && rm -rf ${RPM_BUILD_ROOT}
This check doesn't make much sense. You provide a default build root at
the top. There is no evidence that anybody ever builds rpms as superuser
and overrides the build root at the same time.
> GraphicsMagick>=1
Is this available in Core or Extras?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list