[Bug 177270] Review Request: libresample - A real-time library for audio sampling rate conversion

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libresample - A real-time library for audio sampling rate conversion


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177270





------- Additional Comments From holbrookbw at users.sourceforge.net  2006-02-16 00:45 EST -------
(This goes along with Packaging Guidelines) Your %description is a
copy-and-paste of Summary, very brief... Anything else you can say in Description?

rpmlint: OK
naming guidelines: OK
  NOTE: FE caveats use "Release: 1%{?dist}" instead of just "Release: 1"
name matches base package: OK
specfile matches base package: OK
  Note: your .spec file in the SRPM is named correctly, but the one you linked
here "libresample-0.1.3-1.spec" is not
packaging guidelines: OK
LGPL License: OK
LICENCE.txt file matches (and included in %doc): OK
  Might consider renaming to "COPYING" and dropping the ".txt" off of "README.txt"
legible: OK
md5: OK
  99bc5ea15ef76b83e5655a10968f674b  SOURCES/libresample-0.1.3.tgz
  99bc5ea15ef76b83e5655a10968f674b  libresample-0.1.3.tgz
successful build:
  i386=OK
  ppc=OK
  x64=UNKNOWN ( Nothing to try it on :-/ )
BuildRequires: NONE
ldconfig: OK
ownership/permissions: OK
no duplicate %files: OK
%clean: OK
consistent macros: OK
libraries in -devel package: OK
  NOTE: -devel does NOT require the base package, because there is no base
package :)

No blocking issues, APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.